GTcreyon / SM63Redux

Code base for Super Mario 63 Redux

https://sm63redux.com

Mozilla Public License 2.0

193 stars 25 forks source link

Generalize solid-object scripts #291

Closed Koopa1018 closed 5 months ago

Koopa1018 commented 5 months ago

Description of changes

Renames log.gd to solid_object.gd, and big_rock.gd to solid_object_mirrorable.gd. Also moves both of these scripts directly into classes/solid out of their subfolders. Neither of these scripts actually has anything specific to rocks or logs--one lets the LD disable a StaticBody2D, the other lets the LD disable and mirror a StaticBody2D. This seems useful for many different solid object types.

Issue(s)

Minor issue noted during #286.

Koopa1018 commented 5 months ago

Notes from Discord:

Forgot to make collision polygons mirror with sprites. Mirrored rocks thus have wrong collision.
Disabling is bugged, and would be better done via disabling anyway
Hardcoded $Sprite2D node path is not ideal, should be an export variable