GTkorvo / dill

DILL provides instruction-level code generation, register allocation and simple optimizations for generating executable code directly into memory regions for immediate use.
Other
5 stars 6 forks source link

Resolve bash executable path through the PATH variable #47

Closed yurivict closed 7 months ago

eisenhauer commented 7 months ago

I'm less clear on the need for this. As far as I know /bin/bash exists most everywhere (and certainly on the systems where the ci scripts are run. Is there somewhere that /bin/bash is unavailable which causes problems in dill-config?

yurivict commented 7 months ago

As far as I know /bin/bash exists most everywhere ...

No.

On FreeBSD and all *BSDs bash is in /usr/local/bin/bash.

bash in general can be installed anywhere, but is usually installed in /bin/bash.

yurivict commented 7 months ago

bash is not a part of the operating system.

bash is one of shells. It is just another package that is usually installed by users. There are other shells as well.

eisenhauer commented 7 months ago

Yeah, I did BSD 4.2 on a VAX back in the day, but of course that was before bash. I'm happy to accept the change to dill-config.in, since that will run in a target environment, but I'll keep the direct reference to /bin/bash in the CI platforms until such a time as we're running CI on a platform that needs the change.

yurivict commented 7 months ago

Ok. I'd close this then since this isn't critical.