GTorlai / PastaQ.jl

Package for Simulation, Tomography and Analysis of Quantum Computers
Apache License 2.0
142 stars 23 forks source link

Maybe change input ordering of tomography function #103

Closed mtfishman closed 3 years ago

mtfishman commented 3 years ago

To me, it is more natural to list the data first in the tomography function (instead of the initial starting state), since that is what is being learned so is more important. Also, the starting state could be optional (i.e. we could initialize it automatically), and generally it is better to put more "optional" things later in the input list.

Also, it might be nice to pass the optimizer as a keyword argument optimizer = .... So for example:

tomography(data_in, data_out, V0;
           optimizer = opt;
           batchsize = 100,
           epochs = 2,
           target = U)
mtfishman commented 3 years ago

Closed by #109.