search

GTorlai / PastaQ.jl

Package for Simulation, Tomography and Analysis of Quantum Computers
Apache License 2.0
142 stars 23 forks source link

Introduce `PastaQ.normalize!` to distinguish from `ITensors.normalize!` #259

Closed mtfishman closed 2 years ago

mtfishman commented 2 years ago

https://github.com/ITensor/ITensors.jl/pull/820 introduces ITensors.normalize! (actually an overload of LinearAlgebra.normalize!).

Unfortunately the definition there uses the Frobenius norm. I would like to generalize it to allow for other norms, but for now it conflicts with the version in PastaQ. This addresses that issue by changing the notation of the PastaQ normalize! that normalizes by the trace (in the case of operators) to the unexported PastaQ.normalize!.