search

GTorlai / PastaQ.jl

Package for Simulation, Tomography and Analysis of Quantum Computers
Apache License 2.0
142 stars 23 forks source link

Update for the latest SCS interface #286

Closed mtfishman closed 2 years ago

mtfishman commented 2 years ago

@GTorlai the change was pretty simple, though the documentation for SCS/Convex was a bit lacking... Not sure why the interface become so much more verbose!

The only slightly concerning thing is that the results changed a bit. I didn't compare carefully, I just saw some tests failed and to make them pass I had to loosen the bounds on some tests. Do you think it matters?

Closes #284.

codecov-commenter commented 2 years ago

Codecov Report

Merging #286 (22aa850) into master (eb4d694) will increase coverage by 0.01%. The diff coverage is 100.00%.

:exclamation: Current head 22aa850 differs from pull request most recent head fb6f03e. Consider uploading reports for the commit fb6f03e to get more accurate results

@@            Coverage Diff             @@
##           master     #286      +/-   ##
==========================================
+ Coverage   87.51%   87.52%   +0.01%     
==========================================
  Files          22       22              
  Lines        2298     2300       +2     
==========================================
+ Hits         2011     2013       +2     
  Misses        287      287
Impacted Files Coverage Δ
src/tomography/fulltomography.jl 97.34% <100.00%> (+0.04%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update eb4d694...fb6f03e. Read the comment docs.