Closed mtfishman closed 3 years ago
@GTorlai, let me know what you think of these changes, I could implement them this week. Open to suggestions about the function names, keyword argument names, etc.
Sounds good, let me first merge the Choi matrix branch
This is partially implemented in #62. What remains is incorporating twoqubitlayer!
into appendlayer!
with a keyword argument nqubit = 2
.
There are many functions that do similar things, like:
hadamardlayer
hadamardlayer!
randomrotationlayer
randomrotationlayer!
twoqubitlayer
twoqubitlayer!
It seems like we could compress this into a unified interface, for example:
and
randomrotation
could be implemented through thegate
interface with a specialGateName
, for examplegate("randrot", s)
. Then,randomrotation[!]
could be replaced by:Also, the two-qubit layer could be determined automatically internally, or be specified with a keyword argument. I think a keyword argument may be best, such as:
Also, we could probably just simplify:
randomquantumcircuit
->randomcircuit