Replace `fullfidelity(::MPO, ::MPO)` with `fidelity(::ITensor, ::ITensor)`

GTorlai / PastaQ.jl

Package for Simulation, Tomography and Analysis of Quantum Computers

Apache License 2.0

145 stars 23 forks source link

Replace `fullfidelity(::MPO, ::MPO)` with `fidelity(::ITensor, ::ITensor)` #94

Closed mtfishman closed 4 years ago

mtfishman commented 4 years ago

fullfidelity is not my favorite name. Instead, we could define fidelity(::ITensor, ::ITensor), and then tell people to use fidelity(prod(rho), prod(sigma)). We can also define fidelity(::MPO, ::MPO) and just make it throw an error, telling people to use fidelity(::ITensor, ::ITensor) instead.

mtfishman commented 4 years ago

I'm going to remove this from v0.0.1, since it is not really blocking a release. I removed fullfidelity from exports.jl in #109, and we can add this as a feature later.