search

GU-99 / grow-up-fe

MIT License
2 stars 1 forks source link

Chore: #231 이메일 인증 관련 코드 검토 및 주석 제거 #234

Closed Yoonyesol closed 1 month ago

Yoonyesol commented 1 month ago

PR Type

What kind of change does this PR introduce?

Related Issues

What does this PR do?

Other information

coderabbitai[bot] commented 1 month ago

Walkthrough

이 Pull Request는 사용자 인증 및 검증 프로세스를 처리하는 authServiceHandler, UserPasswordSettingPage, authService, 및 userService 파일에서 여러 가지 수정 사항을 도입합니다. 주요 변경 사항으로는 이메일 검증 코드 처리 시 응답 상태 코드가 401에서 400으로 변경되었고, 사용자 복구 API에서도 유사한 상태 코드 변경이 이루어졌습니다. 또한, UserPasswordSettingPage 컴포넌트에서 주석 처리된 코드가 활성화되었으며, 여러 비동기 함수의 반환 타입이 Promise<AxiosResponse>에서 Promise<AxiosResponse<void>>로 수정되었습니다.

Changes

파일 경로 변경 요약
src/mocks/services/authServiceHandler.ts 이메일 검증 코드 및 사용자 복구 API의 응답 상태 코드 변경 (401 → 400)
src/pages/setting/UserPasswordSettingPage.tsx 주석 처리된 useEffect 및 useStore 임포트 문 활성화 및 관련 코드 재활성화
src/services/authService.ts 여러 비동기 함수의 반환 타입을 Promise<AxiosResponse>에서 Promise<AxiosResponse<void>>로 변경
src/services/userService.ts updateLinks 함수의 반환 타입을 Promise<AxiosResponse>에서 Promise<AxiosResponse<void>>로 변경

Assessment against linked issues

Objective Addressed Explanation
이메일 인증 로직 구현 수정 (#231, #146) ✅
이메일 인증 정보를 Zustand에 지정된 시간 동안 저장 (#146) ❌ 이 PR에서 관련된 상태 저장 로직이 구현되지 않음.
인증 정보 만료 시, 인증 페이지로 리다이렉션 (#146) ❓ 리다이렉션 로직의 구현 여부가 불확실함.

Possibly related PRs

Suggested labels

💉 Fix

Suggested reviewers

🐰 변화의 기쁨을 노래해요,
인증의 길을 함께 걸어요.
코드가 바뀌고, 기능이 빛나,
우리 모두의 소중한 데이터,
안전하게 지켜줄 거예요.
함께하는 이 순간, 행복해요! 🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
Yoonyesol commented 1 month ago

@Seok93 진호님께서 해당 API를 작업해 주셔서, 주석 처리는 제거해도 된다고 생각했습니다! 그때 혹시 활성화하면 안 되는 다른 이유가 있다고 말씀하셨었나요?😮 전 잘... 기억이 안 나서요🥲