search

GU-99 / grow-up-fe

MIT License
2 stars 1 forks source link

Chore: #236 axiosProvider에서 JWT 더미데이터 삭제 #237

Closed Yoonyesol closed 1 month ago

Yoonyesol commented 1 month ago

PR Type

What kind of change does this PR introduce?

Related Issues

What does this PR do?

Other information

새로고침 시 isAuthenticated가 초기화되면서 헤더에 로그아웃 버튼 대신 로그인 버튼이 노출되는 이슈가 있었습니다. 이를 해결하고자 임시방편으로 이전 PR과 같이 영속 데이터인 userId를 체크하도록 코드를 추가했습니다. 추후 PR에서 새로고침 이슈 해결하면서 이 부분도 수정 진행하도록 하겠습니다!😆

coderabbitai[bot] commented 1 month ago

Walkthrough

이 변경 사항은 Header 컴포넌트와 axiosProvider 인스턴스의 인증 관련 로직을 수정합니다. Header 컴포넌트에서는 로그아웃 버튼의 onClick 핸들러가 isAuthenticated 또는 userInfoData.userId가 참인지 확인하여 로그아웃 기능을 트리거하도록 변경되었습니다. axiosProvider에서는 하드코딩된 Authorization 헤더를 제거하고, 현재 액세스 토큰을 기반으로 동적으로 설정하도록 수정되었습니다.

Changes

파일 경로 변경 요약
src/components/common/Header.tsx 버튼의 onClick 핸들러가 isAuthenticated 또는 userInfoData.userId를 확인하도록 수정. 버튼 텍스트가 조건에 따라 "Logout"으로 변경됨.
src/services/axiosProvider.ts 하드코딩된 Authorization 헤더 삭제, 요청 인터셉터에서 액세스 토큰을 기반으로 헤더 설정. 함수 시그니처 업데이트.

Assessment against linked issues

Objective Addressed Explanation
axiosProvider에서 JWT 더미데이터 삭제 (#236) ✅

Possibly related PRs

Suggested labels

🛠️ Refactor, 💉 Fix

Suggested reviewers

🐰 새로운 버튼 클릭, 로그아웃의 길,
사용자 정보로, 더 이상 막힘 없네.
액세스 토큰도, 더 이상 더미가 아니니,
진짜로 로그인, 이제는 자유로이!
✨🐇

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
Yoonyesol commented 1 month ago

@Seok93 리뷰 감사합니다!