search

GUBookSociety / uofg-book-society-website

A website created with Angular for the Glasgow University Book Society. (IN DEVELOPMENT)
1 stars 0 forks source link

Navbar Drawer + General Fixes/Improvements #26

Closed liamlau closed 4 years ago

liamlau commented 4 years ago

Summary

Just cleaning up the navbar and adding a mobile specific navbar drawer

Details of Changes/Features Added

It look a little while to figure out how exactly I was going to do the animated drawer, but I remembered that Bootstrap has just that. But, we're using Angular Material to do the navbar, but fortunately, just slotting the code in for the Bootstrap collapsing navbar worked (with some slight changes).

Other than that, it was relatively simple to link things up from the hamburger button in the previous commits to the drawer (through Bootstrap aria-controls).

I also made the sign in and sign up buttons go to their respective pages (pages without navbars, as sign in and sign up pages usually don't have navbars).

Lastly, I just made sure every link changed colour correctly when hovering over it.

Notes

I actually installed ngBoostrap for this, but I ended up not using it. Oh well, if we need it in the future, it's there.

Issues Closed/Addressed

Closes #25

liamlau commented 4 years ago

I've added comments after most files to say what changes I made to them.

Let me know if there's any problems, or any concerns! 😄

LukeGall commented 4 years ago

Looks excellent, the nav bar is looking very slick and is a great place to base to start the rest of the app from