search

GUDHI / TDA-tutorial

A set of jupyter notebooks for the practice of TDA with the python Gudhi library together with popular machine learning and data sciences libraries.
MIT License
379 stars 115 forks source link

Use some tools to diff notebooks #40

Closed VincentRouvreau closed 1 year ago

VincentRouvreau commented 3 years ago

Some tools like https://www.reviewnb.com/ may be helpful for the reviews

VincentRouvreau commented 3 years ago

I installed reviewnb only for GUDHI/TDA-tutorial. Now, if you want to review https://github.com/GUDHI/TDA-tutorial/pull/25 for instance, you can go to https://app.reviewnb.com/GUDHI/TDA-tutorial/pull/25/ and in changes, you select an *.ipynb file and you will see modifications with a diff tool that renders the notebook (instead of diff on raw notebooks files). It also works for commits, which is quite usefull. Your feedbacks are welcome.

mglisse commented 3 years ago

That looks very nice to me, thank you. Would it be easy to have a link to the corresponding reviewnb appear magically on each PR, or should I keep a bookmark(let) locally for when I need it?

astamm commented 3 years ago

That's pretty neat, thanks @VincentRouvreau. I am wondering whether we can add comments directly in reviewnb. What I mean is that when reviewing code in the Github interface, you can select part of the code and put a comment for that specific selection. Would that be possible to do the same thing while skimming through the changes using reviewnb?

mglisse commented 3 years ago

Yes, it is possible to comment, I did it in #31 to see what it looked like.

VincentRouvreau commented 1 year ago

ReviewNB has been installed on this project