GUDHI / gudhi-devel

The GUDHI library is a generic open source C++ library, with a Python interface, for Topological Data Analysis (TDA) and Higher Dimensional Geometry Understanding.
https://gudhi.inria.fr/
MIT License
254 stars 65 forks source link

Explain requirements #1002

Open mglisse opened 10 months ago

mglisse commented 10 months ago

https://github.com/GUDHI/gudhi-devel/blob/2e94f63b6d329dc410ebe27d393a293901b50a82/src/Simplex_tree/concept/SimplexTreeOptions.h#L18-L19

It would be convenient if we added a comment (it doesn't have to show in the doc) explaining why it needs to be signed, so we can easily figure it out a few years later when we have a use case for an unsigned type.

This is actually a general comment, with Vertex_handle as an example. If there are other non-obvious requirements in other places...