BettiCurve.fit_transform missing y=None param

GUDHI / gudhi-devel

The GUDHI library is a generic open source C++ library, with a Python interface, for Topological Data Analysis (TDA) and Higher Dimensional Geometry Understanding.

https://gudhi.inria.fr/

MIT License

254 stars 65 forks source link

BettiCurve.fit_transform missing y=None param #1022

Closed mglisse closed 3 months ago

mglisse commented 8 months ago

https://github.com/GUDHI/gudhi-devel/blob/e7b6d08f25e35891196ce104a014330da442cf12/src/python/gudhi/representations/vector_methods.py#L409

According to https://scikit-learn.org/stable/developers/develop.html , accepting an extra argument is mandatory, and indeed the current code causes trouble when trying to use BettiCurve with ColumnTransformer.

mglisse commented 3 months ago

Fixed by #1061.