Closed mglisse closed 2 weeks ago
https://github.com/GUDHI/gudhi-devel/blob/e7b6d08f25e35891196ce104a014330da442cf12/src/python/gudhi/representations/vector_methods.py#L382 (there is another one a few lines below) I think this was meant as a short version of len(X)==0, but if X is a numpy array (which is perfectly valid), not does not have the intended behavior.
len(X)==0
not
(replacing an empty list with a list that contains a single empty diagram also looks suspicious, but I did not look at the details)
https://github.com/GUDHI/gudhi-devel/blob/e7b6d08f25e35891196ce104a014330da442cf12/src/python/gudhi/representations/vector_methods.py#L382 (there is another one a few lines below) I think this was meant as a short version of
len(X)==0
, but if X is a numpy array (which is perfectly valid),not
does not have the intended behavior.(replacing an empty list with a list that contains a single empty diagram also looks suspicious, but I did not look at the details)