Representations - kernel_methods : Undefined name `metric`

GUDHI / gudhi-devel

The GUDHI library is a generic open source C++ library, with a Python interface, for Topological Data Analysis (TDA) and Higher Dimensional Geometry Understanding.

https://gudhi.inria.fr/

MIT License

254 stars 65 forks source link

Representations - kernel_methods : Undefined name `metric` #1033

Closed VincentRouvreau closed 7 months ago

VincentRouvreau commented 7 months ago

In _sklearn_wrapper(metric, **kwargs), metric is undefined, cf.

https://github.com/GUDHI/gudhi-devel/blob/06bc78ae0a3d96d1273e37438cfd1f116118385a/src/python/gudhi/representations/kernel_methods.py#L89

MathieuCarriere commented 7 months ago

Yes good catch it should be kernel instead I think

MathieuCarriere commented 7 months ago

Just created PR #1037