search

GUDHI / gudhi-devel

The GUDHI library is a generic open source C++ library, with a Python interface, for Topological Data Analysis (TDA) and Higher Dimensional Geometry Understanding.
https://gudhi.inria.fr/
MIT License
245 stars 65 forks source link

Constructor fix in Bitmap_cubical_complex_periodic_boundary_conditions_base #1054

Closed hschreiber closed 1 month ago

hschreiber commented 1 month ago

The old version didn't compile.

In file included from /src/Bitmap_cubical_complex/include/gudhi/Bitmap_cubical_complex.h:16,
                 from /src/Bitmap_cubical_complex/benchmark/bitmap_cubical_complex_benchmark.cpp:11:
/src/Bitmap_cubical_complex/include/gudhi/Bitmap_cubical_complex_periodic_boundary_conditions_base.h: In constructor ‘Gudhi::cubical_complex::Bitmap_cubical_complex_periodic_boundary_conditions_base<T>::Bitmap_cubical_complex_periodic_boundary_conditions_base(const std::vector<unsigned int>&, const std::vector<bool>&)’:
/src/Bitmap_cubical_complex/include/gudhi/Bitmap_cubical_complex_periodic_boundary_conditions_base.h:346:62: error: no match for call to ‘(std::vector<bool>) (const std::vector<bool>&)’
  346 |   this->directions_in_which_periodic_b_cond_are_to_be_imposed(directions_in_which_periodic_b_cond_are_to_be_imposed);
mglisse commented 1 month ago

The old version didn't compile.

... with g++-14. For some reason all other compilers are fine with it :confused: