Fix Atol for scikit-learn >= 1.4.0

GUDHI / gudhi-devel

The GUDHI library is a generic open source C++ library, with a Python interface, for Topological Data Analysis (TDA) and Higher Dimensional Geometry Understanding.

https://gudhi.inria.fr/

MIT License

245 stars 65 forks source link

Fix Atol for scikit-learn >= 1.4.0 #1056

Closed VincentRouvreau closed 3 weeks ago

VincentRouvreau commented 1 month ago

Fix #1031 Sorry @martinroyer I was not able to keep the history while taking your changes from #1017 but merging #1017 will still be possible in the future.

VincentRouvreau commented 3 weeks ago

ok, though I would appreciate a comment on #1056 (comment) (the values may be fine, but using different default values than sklearn deserves in my opinion a quick justification, for instance as a comment in the source code).

57563ef I put the comment in the doc. The rendering (some sphinx dependencies were updated):