search

GUDHI / gudhi-devel

The GUDHI library is a generic open source C++ library, with a Python interface, for Topological Data Analysis (TDA) and Higher Dimensional Geometry Understanding.
https://gudhi.inria.fr/
MIT License
245 stars 65 forks source link

Fix for #1023 #1062

Closed MathieuCarriere closed 2 weeks ago

MathieuCarriere commented 4 weeks ago

I think the replacement of the empty list with a list containing the empty diagram was to ensure that the events, starts and ends variables does not crash.

Fix #1023

mglisse commented 4 weeks ago

If we transform a list of n diagrams, shouldn't we output a list of size n, even when n=0? I.e. why not just return []? For fittransform... how well do we support fit([])? With default parameters, it looks like we build a `grid` where all the coordinates are NaN, could be worse.

MathieuCarriere commented 3 weeks ago

Yes indeed, good catch. I added a few if conditions to make the outputs consistent.

MathieuCarriere commented 3 weeks ago

Thank you for the comments! I've pushed a few fixes according to your suggestions (that I agree with).

VincentRouvreau commented 2 weeks ago

Ok for me, but @VincentRouvreau will need to fix the gudhi-deploy thing before merging this branch.

Reverted on 2a2e764