search

GUDHI / gudhi-devel

The GUDHI library is a generic open source C++ library, with a Python interface, for Topological Data Analysis (TDA) and Higher Dimensional Geometry Understanding.
https://gudhi.inria.fr/
MIT License
245 stars 65 forks source link

Fix for #1048 #1063

Closed MathieuCarriere closed 3 weeks ago

MathieuCarriere commented 4 weeks ago

I removed the dynamic argument in the tensorflow models so that the code does not crash with new versions of tensorflow. I also tried running the code with an old tensorflow version (2.14) for retrocompatibility, and had no issues.

Fix #1048

mglisse commented 4 weeks ago

Did you see @VincentRouvreau 's #1058 ? (there is a link to it in #1048) IIUC, you are saying that his workaround with TensorflowKerasLayer to use dynamic=True only for old versions is unnecessary?

MathieuCarriere commented 3 weeks ago

Ah my bad, I missed @VincentRouvreau 's #1058. What I did was indeed to check that dynamic=True is not mandatory even for older tensorflow versions. However, I did not run extensive checks (I only made sure that the tutorials + tests were working fine), so it might be safer to just check the tensorflow version.

mglisse commented 3 weeks ago

@VincentRouvreau this one is up to you.