search

GUDHI / gudhi-devel

The GUDHI library is a generic open source C++ library, with a Python interface, for Topological Data Analysis (TDA) and Higher Dimensional Geometry Understanding.
https://gudhi.inria.fr/
MIT License
245 stars 65 forks source link

Tweak default parameters of KMeans in Atol #1072

Closed mglisse closed 2 weeks ago

mglisse commented 2 weeks ago

Refer to https://github.com/GUDHI/gudhi-devel/pull/1056#discussion_r1636010293

Sphinx is nice enough to show only KMeans(n_clusters=2), i.e. it hides n_init="auto", probably because it is the default. I don't know how good that is in general, but here where we only specify n_init to avoid warnings with old versions of scikit-learn, that's very cool.

@martinroyer, @VincentRouvreau, no objection?

VincentRouvreau commented 2 weeks ago

I do not have the behaviour you mention about sphinx on my side: image

I have: pydata-sphinx-theme 0.15.2 Sphinx 7.3.7 sphinx-paramlinks 0.6.0 sphinxcontrib-applehelp 1.0.8 sphinxcontrib-bibtex 2.6.2 sphinxcontrib-devhelp 1.0.6 sphinxcontrib-htmlhelp 2.0.5 sphinxcontrib-jsmath 1.0.1 sphinxcontrib-qthelp 1.0.7 sphinxcontrib-serializinghtml 1.1.10

And on the CI, that have the behaviour you mention: pydata-sphinx-theme 0.15.3 Sphinx 7.3.7 sphinx-paramlinks 0.6.0 (the rest, I don't know)

But this is still ok to me