GUDHI / gudhi-devel

The GUDHI library is a generic open source C++ library, with a Python interface, for Topological Data Analysis (TDA) and Higher Dimensional Geometry Understanding.
https://gudhi.inria.fr/
MIT License
245 stars 65 forks source link

Change default dim in DTMDensity for high dimension #1075

Open mglisse opened 2 weeks ago

mglisse commented 2 weeks ago

In DTMDensity (and Tomato), when the points are in "high" dimension, we recommend using a small value for dim instead of the default: the ambient dimension. But if we recommend it, why not make it the default behavior? Something like

DTMDensity (without normalization) ends with density = dtm ** (-dim / q). This exponentiation is pretty useless if we are only going to use it in a log in Tomato's logDTM. Without it, only q needs to be small enough, dim becomes unused, and the behavior matches Tomato's doc before #1074.