GUDHI / gudhi-devel

The GUDHI library is a generic open source C++ library, with a Python interface, for Topological Data Analysis (TDA) and Higher Dimensional Geometry Understanding.
https://gudhi.inria.fr/
MIT License
245 stars 65 forks source link

Some robustifying fixes on Atol fit and tests for vectorizers #1096

Open martinroyer opened 6 days ago

martinroyer commented 6 days ago

This introduces fixes that allow Atol to not crash on fitting, essentially by adding random points to the target. This is a follow-up on PR #1017 that can now be dropped.

Option: I add a series of test that only test Atol for now, but are ready to be extended to all vectorization methods. So one could work on another vector method and directly use the same test battery to see if there's a problem with this method's:

(naturally we could also work on the interface as a separate PR where we deal with the transform_one question too, see https://github.com/GUDHI/gudhi-devel/pull/1056#discussion_r1625083965.)