search

GUDHI / gudhi-devel

The GUDHI library is a generic open source C++ library, with a Python interface, for Topological Data Analysis (TDA) and Higher Dimensional Geometry Understanding.
https://gudhi.inria.fr/
MIT License
259 stars 66 forks source link

[Persistence Matrix] Addition of small vectors as a column type #1154

Open hschreiber opened 2 weeks ago

hschreiber commented 2 weeks ago

Replacing std::vector with boost::container::small_vector in Naive_vector_column showed some run time improvements on some particular use cases in multipers. So I added the possibility in the column choices.

hschreiber commented 2 weeks ago

Would the same templatization make sense for Vector_column? Maybe it does but you consider that class useless?

It makes indeed also sense for Vector_column. It's just that Vector_column only works better when a lot of entries are manually cleared inside the column, which for now only happens during vineyard with RU. And in that case, the small vector do not seem to make things much better. At least in multipersistence. And I am wondering a bit, if the class is not indeed useless as you say, as using a set kind of works better in that particular case anyway...