search

GUDHI / gudhi-devel

The GUDHI library is a generic open source C++ library, with a Python interface, for Topological Data Analysis (TDA) and Higher Dimensional Geometry Understanding.
https://gudhi.inria.fr/
MIT License
246 stars 65 forks source link

small fixes on atol methods/class #960

Closed martinroyer closed 9 months ago

mglisse commented 10 months ago

Thanks. I notice there are 2 uses of pairwise.pairwise_distances left, are those safe?

martinroyer commented 10 months ago

Thanks. I notice there are 2 uses of pairwise.pairwise_distances left, are those safe?

They were not, you are right thank you! I made the fitting modifications so that they now are. It is now awkward that both cdist and pairwise are in use, but it makes sense because in one case I want to raise ValueError and not in the other... But we could use cdist only if it is too awkward.