GUDHI / gudhi-devel

The GUDHI library is a generic open source C++ library, with a Python interface, for Topological Data Analysis (TDA) and Higher Dimensional Geometry Understanding.
https://gudhi.inria.fr/
MIT License
246 stars 65 forks source link

remove_if unused result #964

Closed mglisse closed 10 months ago

mglisse commented 10 months ago

https://github.com/GUDHI/gudhi-devel/blob/911ee9d797a1fb328ee19441d6bf621d7a99ff75/src/Subsampling/include/gudhi/choose_n_farthest_points.h#L323 clang++ with libc++ warns that it is suspicious not to use the return value of remove_if. I need to look at this code again and either actually use the return value, or add a comment explaining why not.