search

GUDHI / gudhi-devel

The GUDHI library is a generic open source C++ library, with a Python interface, for Topological Data Analysis (TDA) and Higher Dimensional Geometry Understanding.
https://gudhi.inria.fr/
MIT License
246 stars 65 forks source link

[Simplex tree] Avoid final substraction in dimension computation #972

Closed VincentRouvreau closed 3 weeks ago

VincentRouvreau commented 9 months ago 
          I wonder why we don't initialize `dim` to -1 instead of 0 to avoid this final subtraction, but it isn't new in this PR.

_Originally posted by @mglisse in https://github.com/GUDHI/gudhi-devel/pull/886#discussion_r1333557810_

mglisse commented 3 weeks ago

It looks like this was done in #886.