GUDHI / gudhi-devel

The GUDHI library is a generic open source C++ library, with a Python interface, for Topological Data Analysis (TDA) and Higher Dimensional Geometry Understanding.
https://gudhi.inria.fr/
MIT License
254 stars 65 forks source link

Multiparameter simplextree, C++ part. #976

Open DavidLapous opened 1 year ago

DavidLapous commented 1 year ago

Cpp part of PR #817. List of changes :

Feel free to move files/functions if they don't follow Gudhi's standard, or commit if its moral changes.

DavidLapous commented 1 year ago

I'm not sure why the ci Tangential complex test fails on git, I cannot reproduce on my laptop & it doesn't fail on the other pipelines

DavidLapous commented 1 year ago

@VincentRouvreau I've added your tests to the end of the test file, for the NaN and I had add some checks in the multi filtration file so that the behavior of NaN and inf so that inf and nan filtration values have a proper behavior

Furthermore, thanks to your test (Merci !! 😉) I noticed that there was a bug on the make_filtration_non_decreasing in the multiparameter case, which sometimes allows non-increasing values of simplices, that's why I had to change this line

https://github.com/GUDHI/gudhi-devel/blob/a89ff98f87eb6614cdfe8f3fcd8560319a008d71/src/Simplex_tree/test/simplex_tree_multi_unit_test.cpp#L933

I've only changed this line and the last test, I hope it didn't break the spirit of your test

DavidLapous commented 3 months ago

Changes since last time: