Open DavidLapous opened 1 year ago
I'm not sure why the ci Tangential complex test fails on git, I cannot reproduce on my laptop & it doesn't fail on the other pipelines
@VincentRouvreau I've added your tests to the end of the test file, for the NaN and I had add some checks in the multi filtration file so that the behavior of NaN and inf so that inf and nan filtration values have a proper behavior
Furthermore, thanks to your test (Merci !! 😉) I noticed that there was a bug on the make_filtration_non_decreasing
in the multiparameter case, which sometimes allows non-increasing values of simplices, that's why I had to change this line
I've only changed this line and the last test, I hope it didn't break the spirit of your test
Changes since last time:
Cpp part of PR #817. List of changes :
is_multi_parameter
flag in the simplextree's options to deal with filtration values that behave as array-like instead of float-like.null_value
andinf_
filtration_mutable
to have a non-const access to the filtration.assign
behavior of the insert to prevent unwanted behaviors (and stay 1-critical). The filtration property is no longer maintained.Filtration_value
, child ofstd::vector
with numpy-like pointwise operations, inSimplex_tree/multi_filtrations/Finitely_critical_multi_filtrations.h
Simplex_tree/Simplex_tree_multi.h
contains the options of a simplextree multi, functions that can convert a 1-parameter simplextree to a multiparameter simplextree and vice versa, aswell as useful functions to push filtration values on a discrete grid (for discrete computations.Feel free to move files/functions if they don't follow Gudhi's standard, or commit if its moral changes.