search

GUI / nginx-upstream-dynamic-servers

An nginx module to resolve domain names inside upstreams and keep them up to date.
MIT License
311 stars 74 forks source link

Breaks Nginx Stream Module #26

Open RohanNagar opened 6 years ago

RohanNagar commented 6 years ago

When I compile this module with the nginx stream module, which is available since 1.9.0, the stream module breaks. Multiple stream tests are failing and resulting in seg faults.

I can try to fix this myself, but if anyone is still active I would appreciate some insight into why you think this might be happening.

I'm on version 1.13.5 of Nginx.

Thanks!

wandenberg commented 6 years ago

Hi @RohanNagar, I'm trying to fix some known bugs/segfaults in this module. Can you explain the tests that you are doing? Or even better, provide a vagrant/docker/script where the bug can be easily reproduced?

RohanNagar commented 6 years ago

@wandenberg I am compiling Nginx 1.13.5 with this module, and the additional configure flags of

--with-stream --with-stream_ssl_module

I'm then running the core nginx tests found here. Almost all of the stream tests are failing.

Honestly, I'm not too sure what these tests are testing, I'm still new to Nginx. However it does seem like there are memory issues. Many times the tests expect a result and instead are getting undefined or empty strings. Also after many of the tests, the error "worker process exited with signal 11" are printed.

I can make a simple script to download these and run them if you would like.

wandenberg commented 6 years ago

Would be good to have a script. Have you tried to run the tests without the module?

RohanNagar commented 6 years ago

Yes, the tests pass without the module. I will put a script together for you soon.