search

GUI / nginx-upstream-dynamic-servers

An nginx module to resolve domain names inside upstreams and keep them up to date.
MIT License
311 stars 74 forks source link

Make module compatible with more nginx versions #9

Closed wandenberg closed 8 years ago

wandenberg commented 8 years ago

@GUI I have changed the Makefile and updated the code to be compatible with nginx 1.6.2 and 1.9.11 like asked for on issues #2 and #7 respectively.

To run the tests with different setup we can do something like that

# default test suite
make test

# change the nginx version and apply the nearest no_pool patch available
make test nginx_version=1.6.2 nginx_no_pool_version=1.5.9

# change only nginx version, use a no_pool patch with equals version
make test nginx_version=1.7.0

# change nginx, lua modules and other dependencies
make test nginx_version=1.8.0 lua_nginx_module_version=0.10.1rc1 lua_upstream_nginx_module_version=0.04 nginx_no_pool_version=1.9.2

make test nginx_version=1.9.11 lua_nginx_module_version=0.10.1rc1 lua_upstream_nginx_module_version=0.04
GUI commented 8 years ago

Fantastic, thanks! I've given you commit permissions on this repo, so you're welcome to commit directly (but pull requests are still also welcome if you'd like review or discussion).

I'll update CircleCI later this week so that we test against multiple versions on each commit automatically.