search

GULPF / nimquery

Nim library for querying HTML using CSS-selectors (like JavaScripts document.querySelector)
MIT License
134 stars 8 forks source link

Use func instead of proc where appropriate #12

Closed vabresto closed 3 years ago

vabresto commented 3 years ago

Hey, thanks for this great library!

One of my favourite Nim features is the side effects tracking the compiler does, so I made these changes for my own code and wanted to share them back.

I didn't make any changes other than proc -> func. All the tests pass.

Also, VS Code warns that the various functions cannot raise Defect (this is new as of 1.4.0 it seems) - https://nim-lang.org/blog/2020/10/16/version-140-released.html - I thought about just removing them but that's probably better in another PR (not sure if there's any safety value in keeping them around if the compiler doesn't track it anymore). Let me know if you'd like me to include that in this PR as a general clean up.

Thanks!

GULPF commented 3 years ago

Thanks for the contribution, seems like a good change.

Let me know if you'd like me to include that in this PR as a general clean up.

That would be great :)

vabresto commented 3 years ago

Wanted to follow up on this so it's not left hanging - I can't seem to be able to trigger CI runs, but the devel build seems to have failed for an unrelated reason. Is there anything waiting on me or that I can do to help?