GW2Raidar / gw2raidar

A log parsing website for Guild Wars 2 combat logs
http://www.gw2raidar.com
GNU General Public License v3.0
20 stars 14 forks source link

Moving graph SVG's out of background into actual markup #217

Closed ajrdesign closed 6 years ago

ajrdesign commented 6 years ago

I've been poking around with how the graphs are created and I think we can do a lot with how they are currently but one thing that would open a lot of options is moving them out of being a "background" element and just have them drawn into the table cells.

Example: https://codepen.io/ajrdesign/pen/zPZLaZ?editors=1100

I've figured out how to change colors and some things with the current implementation but I don't think I should attempt to move this into this structure as I'll probably mess it up pretty badly. If we can at least get it out of the background element I can take it from there.

ajrdesign commented 6 years ago

Hey @amadanmath

I've set up the first row on this branch: https://github.com/merforga/gw2raidar/tree/newFramework

I'm still only a little ways through fiddling with the layout of this but hopefully you can see where this is going and start to see what changes will need to be made to the graphs being output.

Let me know if you have any questions after taking a look at this.