search

GW2Raidar / gw2raidar

A log parsing website for Guild Wars 2 combat logs
http://www.gw2raidar.com
GNU General Public License v3.0
20 stars 14 forks source link

Arty Fail When should be success #262

Open merforga opened 6 years ago

merforga commented 6 years ago

There's a few of these coming through, I'll try to catch them as I see them but this one should be success. Looks like not detecting anything past Phase 1: https://www.gw2raidar.com/encounter/CirculationDonationsRadiosFlicksBang https://uat.gw2raidar.com/encounter/SessionsAdmissionsShaftDebatePresented

(have set it to success for time being)

merforga commented 6 years ago

https://www.gw2raidar.com/encounter/EliteBiasDigitalVillagesRangers 20180616-222700.evtc.zip

https://www.gw2raidar.com/encounter/ConspiraciesFlourishedKneeledLiabilitiesUsers 20180517-105740.evtc.zip

These were success (showing up on leaderboards) when they're actually failed. All others which i've removed from arty leaderboard seem to follow the same things: 1) All wipe on last phase (ie it shows a short phase 3) 2) Not everyone actually died but considering its a wipe, everyone should have died which means we're missing the last death in the parse somehow 3) The health update on Arty which should technically tell us Arty is still alive seems to not be triggering so it's not flagging as fail.

Any ideas?

Toeofdoom commented 6 years ago

I've uploaded changes that should prevent this, but the side effect I can't easily avoid is that arty and arkk logs will not detect as success after the first run per day (unless we somehow finally sort out the instid issues)

merforga commented 6 years ago

Sorry couldn't chat before.

Hmmm that's not ideal for the hc community since they'll be running multiple times a day =x. Is it possible to do a total damage check instead? It would then limit it to the <1% wipes which i think will be an even smaller sample size.

I know it's a pain for just a few encounters but it would be more robust imo.

Toeofdoom commented 6 years ago

It already checked that the boss was below 3% health, but that check gets confused by the instid stuff I mentioned unfortunately

merforga commented 6 years ago

Not checking the boss health via event status but actually looking at total damage dealt by the group. If it's significantly less than the boss HP then it's most definitely a fail.

merforga commented 6 years ago

@Toeofdoom do you think you'll have time to look at this this weekend or soonish? Basically change the current implementation you did of checking reward box to checking total damage done against Arty's hp (lower margin for error imo)