Sabetha time out of synch

[merforga]

There's apparently a discrepancy of usually around 10 seconds for Sabetha times:

https://www.gw2raidar.com/encounter/FollowsManufacturesCargoCovenantsGatherings https://dps.report/4pkT-20180409-180528_sab

Need to review vod when it's available to see what timer should be but not sure why there is such a large discrepancy .

https://www.twitch.tv/videos/248648556 sabetha 20180409-210527.evtc.zip

5:54 left on kill so should be 3:06 kill time

[merforga]

I think we may need to revisit logic below.

analyser.py line 323

        #time constraints
        start_event = events[events.state_change == parser.StateChange.LOG_START]
        start_timestamp = start_event['value'].iloc[0]
        start_time = start_event['time'].iloc[0]
        encounter_end = events.time.max()
        state_events = self.assemble_state_data(player_only_events, players, encounter_end)
        self.state_events = state_events

Should encounter end be when chest spawn is detected rather than last event in log?

[immortius]

Each of the mechanisms we use to determine success now record time of success.

[merforga]

Version 2.1.4 released on 2018-04-27 08:57:12