search

GW2Raidar / gw2raidar

A log parsing website for Guild Wars 2 combat logs
http://www.gw2raidar.com
GNU General Public License v3.0
20 stars 14 forks source link

Blocked mechanics counted as "fail" #295

Open merforga opened 6 years ago

merforga commented 6 years ago

Currently, if a mechanic like Gorseval slam is blocked, it still counts as being hit in our boss metrics table. We need to filter out events where mechanics are blocked as well similar to how invulnerabled mechanics are filtered out currently.

tomhalstead commented 5 years ago

https://github.com/GW2Raidar/gw2raidar/blob/6790ee5a1c0f026bb3e72347d1b355c66a3b0c85/analyser/bossmetrics.py#L207 The end of this line (events.value > 0) should filter out hits which don't actually deal damage, and other boss mechanics have this check where applicable. I reviewed the footage for several of my static's gorse attempts and my manual counts for hits/evades/blocks/invulns agree with our reported slams. This does mean that they are still counted if mitigated by stability, since the damage does get dealt.