search

GW2Raidar / gw2raidar

A log parsing website for Guild Wars 2 combat logs
http://www.gw2raidar.com
GNU General Public License v3.0
20 stars 14 forks source link

Command+Left Click Leaderboard Encounter doesn't open encounter in new window #301

Closed ajrdesign closed 6 years ago

ajrdesign commented 6 years ago

This might be related to #300. Command+left click doesn't open leaderboard encounters in a new window as you would expect it to but does scroll you to the top of the leaderboard page.

ajrdesign commented 6 years ago

Per some feedback in discord I think this issue might be a site wide issue.

Most links cannot be opened in a new tab. I dug into this a bit because I remembered we fixed this previous to the redesign.

I found the issue, I think, we need to include href on the a tags even if there a JS script firing on-click. Additionally the uk-totop that was introduced on the encounter page (Probably me trying to solve #300 😮 ) was preventing it from opening in a new tab. So I removed that for Encounters and Leaderboards.

The last thing that I can think of is Global stats (user in discord mentioned wanting to open up multiple encounter's Global Stats). I tried but I need a little help from @amadanmath to figure out how to add the correct area id to the href tag.

merforga commented 6 years ago

Version 2.2.0 released on 2018-06-14 09:44:20