GW2Raidar / gw2raidar

A log parsing website for Guild Wars 2 combat logs
http://www.gw2raidar.com
GNU General Public License v3.0
20 stars 14 forks source link

Cater for new SOI Behaviour #325

Closed merforga closed 5 years ago

merforga commented 5 years ago

deltaconnectedYesterday at 9:50 AM "buff duration change" (aka soi) are treated as 0src/server > dst buffapplies where is_offcycle is nonzero, value is the duration extended, and overstack is the new duration of the stack changed. for simulation purposes it just extends any stack that's ticking at the time

Basically need to calculate uptimes based on extended duration as well field. Maybe need to split between old and new version of arc? I dunno.

merforga commented 5 years ago

deltaconnectedToday at 6:14 PM it probably messes with how you handle overstack not by a lot because extension isnt affected by concentration*(edited) fast bandaid is to handle it like if (is_offcycle) BuffSimulationClass->GetCurrentTicking(quickness).timeremaining += value, else {...} long bandaid probably what EI did and give a "source undetectable duration extension" component to incoming (with nothing to generation because undetectable) also enabled singlestack removes unconditionally instead of just stability so logs may be a bit beefier

immortius commented 5 years ago

Hmm, the log I'm looking at has no buff events that are offcycle with value > 0.

immortius commented 5 years ago

Nevermind, got it.

merforga commented 5 years ago

Version 2.3.3 released on 2018-12-23 11:09:59