Analyser: calculate success/fail

[merforga]

Need to check for Deimos.

Add to encounter display.

KC - Success and fail logs.zip

[amadanmath]

Integrated with UI.

[amadanmath]

TODO: Analyse Xera and Deimos logs, see what makes them tick. Currently, both of those cannot detect success by ordinary means.

[merforga]

I think Verandah figured out the Xera success component of this. Can we release that to UAT for testing?

[Toeofdoom]

Correct, xera detects fine with my local version

Also we have a new router so I can start figuring out the deimos stuff :p

[merforga]

Have you pushed the Xera changes to most recent branch? Don't see it referenced here XD

[Toeofdoom]

It should be in the git repo, but I didn't post because deimos doesn't work yet anyway :p

[merforga]

Xera log below is supposed to be success but shows as fail. Not sure why =x. Another 2 i've uploaded have parsed correctly as success so either there's an anomaly in this log file or something else completely. (https://uat.gw2raidar.com/encounter/76)

20170530-225549.evtc.zip

[merforga]

Have uploaded more success logs and they've been parsed fine. It's just this one for some reason O_O

[merforga]

@Toeofdoom to commit fix and @amadanmath to release to UAT

[merforga]

This Deimos log failed for some reason O_O 20170606-205525.evtc.zip

Xera seems fine for now!

[merforga]

Xera now broken the other way. These 2 are fails but showing up as success ( i think these are the correct files)

Related encounters below: https://uat.gw2raidar.com/encounter/205 https://uat.gw2raidar.com/encounter/203

[Uploading 20170609-230509.evtc.zip…]() 20170606-225828.evtc.zip

[Toeofdoom]

Doesn't look like the right files? the first link doesn't work and the second looks very much like a real success

[merforga]

What's the file name for those 2 encounters? The encounters are dated for yesterday night. We did not kill Xera last night =p

[Toeofdoom]

well... the first one is from july 9 but I can't actually download it (try clicking it, it doesn't work) THe second one is from july 6! so it probably is a kill :P

[merforga]

I thought @amadanmath said we stored the file name for the encounters? If you can tell me the file name I'll upload the right ones. The two encounters like I said, are dated for yesterday where we did not kill Xera.

[merforga]

20170609-231718.evtc.zip 20170609-230509.evtc.zip

I'll try uploading again. These seem to coincide to order. Side note, log time in name is different to time recorded. Do we list time started or time ended.

[amadanmath]

The "Time" in the online tool is started_at, expressed in browser's timezone. The time in filename is more or less the same time, expressed in uploader's timezone.

[Toeofdoom]

oh well... I can't see the encounters on uat and don't look up the database directly generally anyway I'll check those files

[Toeofdoom]

huh... in one of those encounters bright died after xera despawned somehow, odd

[Toeofdoom]

Anyway, evidently despawn is not a good criteria for this fight.

[merforga]

Maybe coz he was falling? LUL

[merforga]

20170610-134340.evtc.zip

This one should be success but is marked as fail =(

[merforga]

Another one marked as success but should be a fail https://uat.gw2raidar.com/encounter/265

Log file below (it was uncompressed, to begin with, so you'll need to unzip before uploading)

20170612-222324.zip

[merforga]

Another example of success marked as fail (Xera)

https://uat.gw2raidar.com/encounter/430

[Toeofdoom]

I've removed "despawn" as a win condition, so we should avoid false positives on the other bosses now. Xera now uses the same success detection as deimos in features-archetypes-and-fixed-xera-success

[amadanmath]

Merged.

[merforga]

\o/