search

GWTReact / gwt-react

GWT Java bindings for React
MIT License
91 stars 17 forks source link

Split gwt-react into gwt-react and gwt-react-dom or at least in separate package structures #4

Open ivmarkov opened 7 years ago

ivmarkov commented 7 years ago

The current layout of the GwtReact packages and classes is mixing together "isomorphic" stuff, like components, ReactElement and the React class, with DOM-specific stuff like React.DOM (static inner class of React), DOMElement (resides in the same package as ReactElement, should this even be exposed as an API?), ReactDOM (in the root package).

Since React 0.14, the React core which does not contain DOM-specifics is separated from the DOM rendering classes and utilities. Perhaps, GWTReact can employ a similar package & class layout.

This is in no way a showstopper, or an urgent item, but it would benefit potential users planning to use GwtReact for rendering with React Native.

ivmarkov commented 7 years ago

Probably getting even more important in light of this: https://facebook.github.io/react/blog/2016/11/16/react-v15.4.0.html