search

GWTReact / gwt-react

GWT Java bindings for React
MIT License
91 stars 17 forks source link

Small cleanup (generics, private constructors, remove non-existing API) #5

Closed ivmarkov closed 7 years ago

ivmarkov commented 7 years ago
  1. Turn all usage of raw types into proper generics
  2. Put private constructors into all static classes / classes not instantiatable by the user
  3. Remove non existing APIs from ReactDOM / ReactDOMServer
pstockley commented 7 years ago

Thanks. Can you check-out and compile gwt-react-examples. You will need to make some changes there to be compatible with your raw type changes.

ivmarkov commented 7 years ago

Fair enough - working on the examples.

ivmarkov commented 7 years ago

I've made 3 minor corrections to the newly introduced generic types in React.java and updated the pull request. A pull request for the examples will follow as well.