GWeindel / hmp

Repository for the hmp python package
BSD 3-Clause "New" or "Revised" License
32 stars 8 forks source link

Fix for changing time_step in plot_topo_timecourse #52

Closed jelmerborst closed 1 year ago

jelmerborst commented 1 year ago

When changing step without explicitly setting the RT to be plotted, the RT would be plotted multiplied by the time_step. Ie when using a timestep of 10 and mean RT was 8000 ms, it would be plotted at 80,000 ms, as correction was applied twice.

GWeindel commented 1 year ago

Thanks, Jelmer for this PR and the other one. However, these PR aren't based on the latest version of the main branch. Can you pull/rebase and resuggest these PR with your branch up-to-date? I can also work on the conflicts but there are quite a few so it'll take some time