clustering fixes, do not fix pars, grid decimation

GWeindel / hmp

Repository for the hmp python package

BSD 3-Clause "New" or "Revised" License

32 stars 8 forks source link

clustering fixes, do not fix pars, grid decimation #78

Closed jelmerborst closed 1 year ago

jelmerborst commented 1 year ago

Fixed two problems that caused clustering, or rather estimation, to go wrong:

the decimation of the grid didn't work correctly, with a decimation of 2 there was no change to the number of models (with 5 PCs, 243 models)
due to the addition of fix_pars to the sliding_event arguments, the pool inputs from sliding_event_mags were wrong, setting this new argument to 1...

Can you somehow prevent the changes to the tutorials? I did not intend to change them (though I guess it's also not a problem).

GWeindel commented 1 year ago

I cannot uncheck the changes to the tutorials, could you do a new PR? There are also ways for you to remove these files but I'll probably be longer

jelmerborst commented 1 year ago

I deleted them... but I'm not sure whether I deleted them from the commit or whether they will be deleted if you merge.

GWeindel commented 1 year ago

Not entirely sure either, I think this will delete the files entirely

On Wed, 19 Jul 2023 at 14:11, Jelmer Borst @.***> wrote:

I deleted them... but I'm not sure whether I deleted them from the commit or whether they will be deleted if you merge.

— Reply to this email directly, view it on GitHub https://github.com/GWeindel/hsmm_mvpy/pull/78#issuecomment-1641971725, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG3LE5Y3IY7IGFCFBGRYCILXQ7FINANCNFSM6AAAAAA2PVUHIY . You are receiving this because your review was requested.Message ID: @.***>

jelmerborst commented 1 year ago

Do not merge, can be removed.