Typo in the compute_kid()

GaParmar / clean-fid

PyTorch - FID calculation with proper image resizing and quantization steps [CVPR 2022]

https://www.cs.cmu.edu/~clean-fid/

MIT License

894 stars 68 forks source link

Typo in the compute_kid() #38

Open chacorp opened 1 year ago

chacorp commented 1 year ago

for the Line 391 and 396 in compute_kid(), I think the 'None' should actually be 'feat_model' https://github.com/GaParmar/clean-fid/blob/55ec1683ce3b2615bdbee12cb611f6ea0dc6457f/cleanfid/fid.py#L391

GaParmar commented 1 year ago

Hi,

Thank you for pointing this out! This bug was introduced in v0.1.29. Earlier versions (eg 0.1.28) should not have this issue. I have addressed in the newest version 0.1.30 I just pushed.

-Gaurav