search

GaParmar / clean-fid

PyTorch - FID calculation with proper image resizing and quantization steps [CVPR 2022]
https://www.cs.cmu.edu/~clean-fid/
MIT License
894 stars 68 forks source link

Why pinned requests==2.25.1? #42

Closed aliencaocao closed 1 year ago

aliencaocao commented 1 year ago

This version is pretty old...I just want to know why is it being pinned, as it conflicts with many of the other libraries I have.

ZeroBomb commented 1 year ago

As far I can tell, the only place the requests library is used is in the downloads_helper.py file, and the usage is pretty bog standard. I see no reason to be that strict on requests version.

GaParmar commented 1 year ago

Thanks for pointing this out. I have changed the requests library requirement in the new version (0.1.35)