search

GaZaTu / x11-emoji-picker

Linux XServer emoji picker
MIT License
203 stars 7 forks source link

Feature request: sub-string searching #3

Closed fluffynuts closed 3 years ago

fluffynuts commented 3 years ago

First off, thanks for this project - it works well, is fast and free!

I'd like to propose a feature request though: sub-string searching for emoji:

Consider 😂 (face_with_tears_of_joy) - on a lot of platforms (eg slack), one can get to this with :joy:, so that was my first attempt - no matches. However, I took a guess that it would be something with face, typed that in, and found the emoji I was looking for.

Thoughts?

I could try to cobble together a PR - it's been a while since I was in cpp land tho.

GaZaTu commented 3 years ago

Thx for the compliment. 😚

As for your request, that feature already exists. Although it only activates with 4 or more characters in the search textfield. If you think 3 would be better i'll change it; or atleast make it configurable. 😉

If you're using the 0.7.2 binaries then i'll have to update them on monday because they don't have that feature yet. 😅

In the meantime you can type :joy: literally as the emoji picker supports GitHub emoji codes.

fluffynuts commented 3 years ago

yeah, perhaps I have an old version, but typing tears_of_ doesn't get me to the :joy: emoji (face_with_tears_of_joy). I'm doing something wrong perhaps? need config? if so, whatever config that is might be useful as default?

fluffynuts commented 3 years ago

This is still by far the best emoji picker for linux (imo), but would really like it to be "obvious" to everyone.

fluffynuts commented 3 years ago

version info is probably helpful: I'm using the 0.7.2 AppImage.

GaZaTu commented 3 years ago

yeah i was a lazy cow and didn't update the binaries 🤣; there have been quite a few improvements since then.

i'll upload the 0.8.0 AppImage tomorrow or monday evening. 🤞

GaZaTu commented 3 years ago

Uploaded new binaries. 👌

https://github.com/GaZaTu/x11-emoji-picker/releases/tag/0.8.0

fluffynuts commented 3 years ago

works great, thanks for updating (: