search

GabLeRoux / webextensions-history-browser

🕘 Browse your firefox history like a boss.
https://addons.mozilla.org/en-US/firefox/addon/webextensions-history-browser/
MIT License
20 stars 1 forks source link

Submit version to addons.mozilla.org #2

Closed GabLeRoux closed 6 years ago

GabLeRoux commented 6 years ago

So I tried to submit this, but I'm getting some linter errors even tho I started with linting.

We have enabled a new linter to process your Add-on. Please make sure to report any issues on GitHub
Your add-on failed validation with 221 errors.

    JavaScript syntax error
    JavaScript syntax error
    JavaScript syntax error
    JavaScript syntax error
    JavaScript syntax error
    …and 216 more

They're linking to https://github.com/mozilla/addons-linter/ so I may have to set something like that in the project.

Here's what I tried for the release (started from scratch to make sure release was clean)

git clone github.com/GabLeRoux/webextensions-history-browser
cd webextensions-history-browser
npm i && bower i
webpack -p
cd addon
zip -r webextensions-history-browser.zip ./*

Then I uploaded webextensions-history-browser.zip.

yfdyh000 commented 6 years ago

You should remove unnecessary files from the addon pack. Then use web-ext lint to verification.

GabLeRoux commented 6 years ago

Thanks, I'll definitely try this when I get some more time.

Since I already have eslint running, I suspect it's the bower_component folder that is causing this. (I didn't have a look at the report yet. Had the error and went to bed).

Maybe generating the whole addon from webpack instead of bundling it with the complete bower_component could fix the problem by removing the only unnecessary files.

I tried to bundle everything with webpack, but I had troubles with datatables, jquery and the datatables bootstrap. I'll have to try harder, but npm's version didn't seem up to date compared to bower's version.

A workaround I see could be to use a cdn instead so I could avoid bower_components completely. Would be a reasonable solution for first version, but I'd prefer having a plugin that works even without internet connection.

Concerning the web-ext lint, I suppose it shouldn't be too hard to include this in de dev pipeline in webpack. I even plan to do the extension release creation from travis later.

Thanks for the hints :)

JulioJu commented 6 years ago

I believe it could be very cool to submit this plugin ! There is actually no cool plugin who replaced Norwell ! And there was a lot of user who used it !

:-) !

GabLeRoux commented 6 years ago

I'm looking into this right away, I'll try a bit more with webpack and web-ext lint as I noted above and will update here

JulioJu commented 6 years ago

So cool ! Thanks !

GabLeRoux commented 6 years ago

As I was suspecting, all of the lint errors happen in addon/bower_components folder:

npm i -g web-ext
npm i && bower i
npm run build
web-ext lint -s=addon
web-ext lint output ``` Validation Summary: errors 227 notices 12 warnings 33 ERRORS: Code Message Description File Line Column JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/templates/default.js 6 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/moment.js 7 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/templates/locale-header.js 7 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/templates/test-header.js 7 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/af.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/ar-dz.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/ar-kw.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/ar-ly.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/ar-ma.js 6 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/ar-sa.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/ar-tn.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/ar.js 7 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/az.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/bg.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/be.js 7 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/bm.js 6 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/br.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/bn.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/bo.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/ca.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/bs.js 6 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/cs.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/cv.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/cy.js 6 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/da.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/de-at.js 8 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/de-ch.js 7 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/dv.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/de.js 7 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/el.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/en-au.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/en-ca.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/en-ie.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/en-gb.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/en-nz.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/es-do.js 4 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/eo.js 7 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/es.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/es-us.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/et.js 6 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/eu.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/fa.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/fo.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/fi.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/fr-ca.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/fr-ch.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/fr.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/gd.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/fy.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/gl.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/gom-latn.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/he.js 7 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/gu.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/hi.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/hr.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/hu.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/hy-am.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/id.js 6 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/is.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/it.js 6 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/ja.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/jv.js 6 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/ka.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/km.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/kk.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/kn.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/ko.js 6 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/ky.js 6 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/lb.js 6 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/lo.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/lt.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/lv.js 6 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/me.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/mi.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/mk.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/ml.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/mr.js 6 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/ms-my.js 6 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/ms.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/mt.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/my.js 7 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/nb.js 6 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/ne.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/nl-be.js 6 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/nl.js 6 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/nn.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/pa-in.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/pl.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/pt-br.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/pt.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/ro.js 6 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/ru.js 7 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/sd.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/se.js 6 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/si.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/sk.js 6 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/sl.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/sq.js 7 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/sr.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/sr-cyrl.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/ss.js 6 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/sv.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/sw.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/te.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/ta.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/tet.js 6 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/th.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/tl-ph.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/tr.js 6 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/tzl.js 6 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/tlh.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/tzm-latn.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/tzm.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/ur.js 6 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/uk.js 6 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/uz-latn.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/x-pseudo.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/uz.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/vi.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/yo.js 5 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/zh-cn.js 6 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/zh-hk.js 7 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/locale/zh-tw.js 6 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/create/check-overf… 1 1 low.js JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/create/date-from-a… 1 1 rray.js JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/create/from-anythi… 1 1 ng.js JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/create/from-array.… 1 1 js JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/create/from-object… 1 1 .js JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/create/from-string… 1 1 -and-array.js JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/create/from-string… 1 1 -and-format.js JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/create/from-string… 1 1 .js JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/create/local.js 1 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/create/parsing-fla… 21 1 gs.js JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/create/utc.js 1 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/create/valid.js 1 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/duration/abs.js 3 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/duration/add-subtr… 1 1 act.js JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/duration/as.js 1 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/duration/bubble.js 1 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/duration/clone.js 1 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/duration/construct… 1 1 or.js JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/duration/create.js 1 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/duration/duration.… 2 1 js JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/duration/get.js 1 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/duration/humanize.… 1 1 js JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/duration/iso-strin… 1 1 g.js JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/duration/prototype… 1 1 .js JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/duration/valid.js 1 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/format/format.js 1 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/locale/base-config… 1 1 .js JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/locale/calendar.js 1 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/locale/constructor… 1 1 .js JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/locale/en.js 1 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/locale/formats.js 1 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/locale/invalid.js 1 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/locale/lists.js 1 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/locale/locale.js 2 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/locale/locales.js 1 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/locale/ordinal.js 1 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/locale/pre-post-fo… 1 1 rmat.js JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/locale/prototype.js 1 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/locale/relative.js 1 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/locale/set.js 1 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/moment/add-subtrac… 1 1 t.js JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/moment/calendar.js 1 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/moment/clone.js 1 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/moment/compare.js 1 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/moment/constructor… 1 1 .js JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/moment/creation-da… 1 1 ta.js JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/moment/diff.js 1 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/moment/format.js 1 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/moment/from.js 1 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/moment/get-set.js 1 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/moment/locale.js 1 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/moment/min-max.js 1 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/moment/moment.js 1 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/moment/now.js 1 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/moment/prototype.js 1 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/moment/start-end-o… 1 1 f.js JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/moment/to-type.js 1 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/moment/to.js 1 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/moment/valid.js 1 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/parse/regex.js 1 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/parse/token.js 1 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/units/aliases.js 1 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/units/constants.js 1 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/units/day-of-month… 1 1 .js JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/units/day-of-week.… 1 1 js JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/units/day-of-year.… 1 1 js JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/units/hour.js 1 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/units/millisecond.… 1 1 js JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/units/minute.js 1 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/units/month.js 1 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/units/offset.js 1 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/units/priorities.js 3 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/units/quarter.js 1 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/units/second.js 1 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/units/timestamp.js 1 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/units/timezone.js 1 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/units/units.js 2 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/units/week-calenda… 1 1 r-utils.js JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/units/week-year.js 1 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/units/week.js 1 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/units/year.js 1 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/utils/abs-ceil.js 1 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/utils/abs-floor.js 1 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/utils/abs-round.js 1 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/utils/compare-arra… 1 1 ys.js JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/utils/defaults.js 2 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/utils/deprecate.js 1 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/utils/extend.js 1 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/utils/has-own-prop… 1 1 .js JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/utils/hooks.js 1 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/utils/index-of.js 18 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/utils/is-array.js 1 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/utils/is-date.js 1 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/utils/is-function.… 1 1 js JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/utils/is-number.js 1 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/utils/is-object-em… 1 1 pty.js JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/utils/is-object.js 1 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/utils/is-undefined… 1 1 .js JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/utils/keys.js 1 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/utils/map.js 1 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/utils/mod.js 1 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/utils/some.js 19 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/utils/to-int.js 1 1 JS_SYNTAX_ERROR JavaScript syntax error There is a JavaScript syntax error in your code; validation cannot continue on this file. bower_components/moment/src/lib/utils/zero-fill.js 1 1 NOTICES: Code Message Description File Line Column KNOWN_LIBRARY Known JS library detected JavaScript libraries are discouraged for simple add-ons, but are generally accepted. bower_components/bootstrap/dist/js/bootstrap.min.js KNOWN_LIBRARY Known JS library detected JavaScript libraries are discouraged for simple add-ons, but are generally accepted. bower_components/bootstrap/dist/js/bootstrap.js MOZILLA_COND_OF_USE Violation of Mozilla conditions of use. Words found that violate the Mozilla conditions of use. See bower_components/moment/locale/tzm-latn.js https://www.mozilla.org/en-US/about/legal/acceptable-use/ for more details. MOZILLA_COND_OF_USE Violation of Mozilla conditions of use. Words found that violate the Mozilla conditions of use. See bower_components/moment/locale/vi.js https://www.mozilla.org/en-US/about/legal/acceptable-use/ for more details. MOZILLA_COND_OF_USE Violation of Mozilla conditions of use. Words found that violate the Mozilla conditions of use. See bower_components/moment/src/locale/tzm-latn.js https://www.mozilla.org/en-US/about/legal/acceptable-use/ for more details. MOZILLA_COND_OF_USE Violation of Mozilla conditions of use. Words found that violate the Mozilla conditions of use. See bower_components/moment/src/locale/vi.js https://www.mozilla.org/en-US/about/legal/acceptable-use/ for more details. MOZILLA_COND_OF_USE Violation of Mozilla conditions of use. Words found that violate the Mozilla conditions of use. See bower_components/bootstrap/grunt/npm-shrinkwrap.js… https://www.mozilla.org/en-US/about/legal/acceptable-use/ for more details. on MOZILLA_COND_OF_USE Violation of Mozilla conditions of use. Words found that violate the Mozilla conditions of use. See bower_components/moment/min/locales.min.js https://www.mozilla.org/en-US/about/legal/acceptable-use/ for more details. MOZILLA_COND_OF_USE Violation of Mozilla conditions of use. Words found that violate the Mozilla conditions of use. See bower_components/moment/min/moment-with-locales.mi… https://www.mozilla.org/en-US/about/legal/acceptable-use/ for more details. n.js MOZILLA_COND_OF_USE Violation of Mozilla conditions of use. Words found that violate the Mozilla conditions of use. See bower_components/moment/min/locales.js https://www.mozilla.org/en-US/about/legal/acceptable-use/ for more details. MOZILLA_COND_OF_USE Violation of Mozilla conditions of use. Words found that violate the Mozilla conditions of use. See js/bundle.js https://www.mozilla.org/en-US/about/legal/acceptable-use/ for more details. MOZILLA_COND_OF_USE Violation of Mozilla conditions of use. Words found that violate the Mozilla conditions of use. See bower_components/moment/min/moment-with-locales.js https://www.mozilla.org/en-US/about/legal/acceptable-use/ for more details. WARNINGS: Code Message Description File Line Column UNSAFE_VAR_ASSIGNMENT Unsafe assignment to innerHTML Due to both security and performance concerns, this may not be set using dynamic values which have bower_components/jquery/src/manipulation.js 423 8 not been adequately sanitized. This can lead to security issues or fairly serious performance degradation. UNSAFE_VAR_ASSIGNMENT Unsafe assignment to innerHTML Due to both security and performance concerns, this may not be set using dynamic values which have bower_components/jquery/src/manipulation/buildFrag… 45 5 not been adequately sanitized. This can lead to security issues or fairly serious performance ment.js degradation. UNSAFE_VAR_ASSIGNMENT Unsafe assignment to innerHTML Due to both security and performance concerns, this may not be set using dynamic values which have bower_components/jquery/external/sizzle/dist/sizzl… 749 4 not been adequately sanitized. This can lead to security issues or fairly serious performance e.js degradation. UNSAFE_VAR_ASSIGNMENT Unsafe assignment to innerHTML Due to both security and performance concerns, this may not be set using dynamic values which have bower_components/jquery/external/sizzle/dist/sizzl… 2 6325 not been adequately sanitized. This can lead to security issues or fairly serious performance e.min.js degradation. UNSAFE_VAR_ASSIGNMENT Unsafe assignment to innerHTML Due to both security and performance concerns, this may not be set using dynamic values which have bower_components/jquery/dist/jquery.min.js 2 9944 not been adequately sanitized. This can lead to security issues or fairly serious performance degradation. UNSAFE_VAR_ASSIGNMENT Unsafe assignment to innerHTML Due to both security and performance concerns, this may not be set using dynamic values which have bower_components/jquery/dist/jquery.min.js 2 38077 not been adequately sanitized. This can lead to security issues or fairly serious performance degradation. UNSAFE_VAR_ASSIGNMENT Unsafe assignment to innerHTML Due to both security and performance concerns, this may not be set using dynamic values which have bower_components/jquery/dist/jquery.min.js 2 49620 not been adequately sanitized. This can lead to security issues or fairly serious performance degradation. UNSAFE_VAR_ASSIGNMENT Unsafe assignment to innerHTML Due to both security and performance concerns, this may not be set using dynamic values which have bower_components/jquery/dist/jquery.slim.min.js 2 10136 not been adequately sanitized. This can lead to security issues or fairly serious performance degradation. UNSAFE_VAR_ASSIGNMENT Unsafe assignment to innerHTML Due to both security and performance concerns, this may not be set using dynamic values which have bower_components/jquery/dist/jquery.slim.min.js 2 38269 not been adequately sanitized. This can lead to security issues or fairly serious performance degradation. UNSAFE_VAR_ASSIGNMENT Unsafe assignment to innerHTML Due to both security and performance concerns, this may not be set using dynamic values which have bower_components/jquery/dist/jquery.slim.min.js 2 49812 not been adequately sanitized. This can lead to security issues or fairly serious performance degradation. UNSAFE_VAR_ASSIGNMENT Unsafe assignment to innerHTML Due to both security and performance concerns, this may not be set using dynamic values which have bower_components/datatables/media/js/jquery.dataTa… 22 1 not been adequately sanitized. This can lead to security issues or fairly serious performance bles.min.js degradation. UNSAFE_VAR_ASSIGNMENT Unsafe assignment to innerHTML Due to both security and performance concerns, this may not be set using dynamic values which have bower_components/datatables/media/js/jquery.dataTa… 24 378 not been adequately sanitized. This can lead to security issues or fairly serious performance bles.min.js degradation. UNSAFE_VAR_ASSIGNMENT Unsafe assignment to innerHTML Due to both security and performance concerns, this may not be set using dynamic values which have bower_components/datatables/media/js/jquery.dataTa… 45 279 not been adequately sanitized. This can lead to security issues or fairly serious performance bles.min.js degradation. UNSAFE_VAR_ASSIGNMENT Unsafe assignment to innerHTML Due to both security and performance concerns, this may not be set using dynamic values which have bower_components/datatables/media/js/jquery.dataTa… 58 327 not been adequately sanitized. This can lead to security issues or fairly serious performance bles.min.js degradation. UNSAFE_VAR_ASSIGNMENT Unsafe assignment to innerHTML Due to both security and performance concerns, this may not be set using dynamic values which have bower_components/datatables/media/js/jquery.dataTa… 58 464 not been adequately sanitized. This can lead to security issues or fairly serious performance bles.min.js degradation. UNSAFE_VAR_ASSIGNMENT Unsafe assignment to innerHTML Due to both security and performance concerns, this may not be set using dynamic values which have bower_components/datatables/media/js/jquery.js 2 9968 not been adequately sanitized. This can lead to security issues or fairly serious performance degradation. UNSAFE_VAR_ASSIGNMENT Unsafe assignment to innerHTML Due to both security and performance concerns, this may not be set using dynamic values which have bower_components/datatables/media/js/jquery.js 3 7158 not been adequately sanitized. This can lead to security issues or fairly serious performance degradation. UNSAFE_VAR_ASSIGNMENT Unsafe assignment to outerHTML Due to both security and performance concerns, this may not be set using dynamic values which have bower_components/datatables/media/js/jquery.js 3 20201 not been adequately sanitized. This can lead to security issues or fairly serious performance degradation. UNSAFE_VAR_ASSIGNMENT Unsafe assignment to innerHTML Due to both security and performance concerns, this may not be set using dynamic values which have bower_components/datatables/media/js/jquery.js 3 20276 not been adequately sanitized. This can lead to security issues or fairly serious performance degradation. UNSAFE_VAR_ASSIGNMENT Unsafe assignment to innerHTML Due to both security and performance concerns, this may not be set using dynamic values which have bower_components/datatables/media/js/jquery.js 3 21689 not been adequately sanitized. This can lead to security issues or fairly serious performance degradation. UNSAFE_VAR_ASSIGNMENT Unsafe assignment to innerHTML Due to both security and performance concerns, this may not be set using dynamic values which have bower_components/datatables/media/js/jquery.js 3 23930 not been adequately sanitized. This can lead to security issues or fairly serious performance degradation. DANGEROUS_EVAL The Function constructor is eval. Evaluation of strings as code can lead to security vulnerabilities and performance issues, even in bower_components/datatables/media/js/jquery.js 4 16655 the most innocuous of circumstances. Please avoid using `eval` and the `Function` constructor when at all possible.' UNSAFE_VAR_ASSIGNMENT Unsafe assignment to innerHTML Due to both security and performance concerns, this may not be set using dynamic values which have bower_components/jquery/dist/jquery.slim.js 1248 4 not been adequately sanitized. This can lead to security issues or fairly serious performance degradation. UNSAFE_VAR_ASSIGNMENT Unsafe assignment to innerHTML Due to both security and performance concerns, this may not be set using dynamic values which have bower_components/jquery/dist/jquery.slim.js 4773 5 not been adequately sanitized. This can lead to security issues or fairly serious performance degradation. UNSAFE_VAR_ASSIGNMENT Unsafe assignment to innerHTML Due to both security and performance concerns, this may not be set using dynamic values which have bower_components/jquery/dist/jquery.slim.js 5981 8 not been adequately sanitized. This can lead to security issues or fairly serious performance degradation. UNSAFE_VAR_ASSIGNMENT Unsafe assignment to innerHTML Due to both security and performance concerns, this may not be set using dynamic values which have bower_components/jquery/dist/jquery.js 1248 4 not been adequately sanitized. This can lead to security issues or fairly serious performance degradation. UNSAFE_VAR_ASSIGNMENT Unsafe assignment to innerHTML Due to both security and performance concerns, this may not be set using dynamic values which have bower_components/jquery/dist/jquery.js 4773 5 not been adequately sanitized. This can lead to security issues or fairly serious performance degradation. UNSAFE_VAR_ASSIGNMENT Unsafe assignment to innerHTML Due to both security and performance concerns, this may not be set using dynamic values which have bower_components/jquery/dist/jquery.js 5981 8 not been adequately sanitized. This can lead to security issues or fairly serious performance degradation. UNSAFE_VAR_ASSIGNMENT Unsafe assignment to innerHTML Due to both security and performance concerns, this may not be set using dynamic values which have bower_components/datatables/media/js/jquery.dataTa… 2888 4 not been adequately sanitized. This can lead to security issues or fairly serious performance bles.js degradation. UNSAFE_VAR_ASSIGNMENT Unsafe assignment to innerHTML Due to both security and performance concerns, this may not be set using dynamic values which have bower_components/datatables/media/js/jquery.dataTa… 3104 6 not been adequately sanitized. This can lead to security issues or fairly serious performance bles.js degradation. UNSAFE_VAR_ASSIGNMENT Unsafe assignment to innerHTML Due to both security and performance concerns, this may not be set using dynamic values which have bower_components/datatables/media/js/jquery.dataTa… 4514 7 not been adequately sanitized. This can lead to security issues or fairly serious performance bles.js degradation. UNSAFE_VAR_ASSIGNMENT Unsafe assignment to innerHTML Due to both security and performance concerns, this may not be set using dynamic values which have bower_components/datatables/media/js/jquery.dataTa… 5363 4 not been adequately sanitized. This can lead to security issues or fairly serious performance bles.js degradation. UNSAFE_VAR_ASSIGNMENT Unsafe assignment to innerHTML Due to both security and performance concerns, this may not be set using dynamic values which have bower_components/datatables/media/js/jquery.dataTa… 5370 5 not been adequately sanitized. This can lead to security issues or fairly serious performance bles.js degradation. ```

Currently trying to get rid of bower_components and bundle everything myself with webpack and node_modules. Will time frame this to 1h. If I'm not done with it after this, I'll send my work in a branch will use a CDN for the release.

GabLeRoux commented 6 years ago

I think I'll be ok with #5 in place, I ran web-ext lint again and I don't have errors anymore. Only a few warnings and notices which are probably all fine. Expect a version on addons.mozilla.org soon :)

npm run lint

> webextensions-history-browser@1.0.0 lint /Users/gableroux/repos/firefox-extensions/webextensions-history-browser
> eslint . && web-ext lint -s=addon

Validation Summary:

errors          0
notices         1
warnings        8

NOTICES:

Code                  Message                                   Description                                                                   File           Line   Column
MOZILLA_COND_OF_USE   Violation of Mozilla conditions of use.   Words found that violate the Mozilla conditions of use. See                   js/bundle.js
                                                                https://www.mozilla.org/en-US/about/legal/acceptable-use/ for more details.
WARNINGS:

Code                    Message                          Description                                                                                          File           Line    Column
UNSAFE_VAR_ASSIGNMENT   Unsafe assignment to innerHTML   Due to both security and performance concerns, this may not be set using dynamic values which have   js/bundle.js   5829    4
                                                         not been adequately sanitized. This can lead to security issues or fairly serious performance
                                                         degradation.
UNSAFE_VAR_ASSIGNMENT   Unsafe assignment to innerHTML   Due to both security and performance concerns, this may not be set using dynamic values which have   js/bundle.js   9338    5
                                                         not been adequately sanitized. This can lead to security issues or fairly serious performance
                                                         degradation.
UNSAFE_VAR_ASSIGNMENT   Unsafe assignment to innerHTML   Due to both security and performance concerns, this may not be set using dynamic values which have   js/bundle.js   10549   8
                                                         not been adequately sanitized. This can lead to security issues or fairly serious performance
                                                         degradation.
UNSAFE_VAR_ASSIGNMENT   Unsafe assignment to innerHTML   Due to both security and performance concerns, this may not be set using dynamic values which have   js/bundle.js   29604   4
                                                         not been adequately sanitized. This can lead to security issues or fairly serious performance
                                                         degradation.
UNSAFE_VAR_ASSIGNMENT   Unsafe assignment to innerHTML   Due to both security and performance concerns, this may not be set using dynamic values which have   js/bundle.js   29820   6
                                                         not been adequately sanitized. This can lead to security issues or fairly serious performance
                                                         degradation.
UNSAFE_VAR_ASSIGNMENT   Unsafe assignment to innerHTML   Due to both security and performance concerns, this may not be set using dynamic values which have   js/bundle.js   31230   7
                                                         not been adequately sanitized. This can lead to security issues or fairly serious performance
                                                         degradation.
UNSAFE_VAR_ASSIGNMENT   Unsafe assignment to innerHTML   Due to both security and performance concerns, this may not be set using dynamic values which have   js/bundle.js   32079   4
                                                         not been adequately sanitized. This can lead to security issues or fairly serious performance
                                                         degradation.
UNSAFE_VAR_ASSIGNMENT   Unsafe assignment to innerHTML   Due to both security and performance concerns, this may not be set using dynamic values which have   js/bundle.js   32086   5
                                                         not been adequately sanitized. This can lead to security issues or fairly serious performance
                                                         degradation.

Only a small issue with bootstrap fonts and webpack left 👍

GabLeRoux commented 6 years ago

Doing the submission process right now

image

Only warning s so everything should be ok 🍻

GabLeRoux commented 6 years ago

Hello,

Your add-on, webextensions History Browser 1.0.0, has been approved and is now available for download in our gallery at https://addons.mozilla.org/addon/webextensions-history-browser/

Reviewer: Mozilla

Comments: This version has been screened and approved for the public. Keep in mind that other reviewers may look into this version in the future and determine that it requires changes or should be taken down. In that case, you will be notified again with details and next steps.

Thank you!

🎉