GabLeRoux / webextensions-history-browser

🕘 Browse your firefox history like a boss.
https://addons.mozilla.org/en-US/firefox/addon/webextensions-history-browser/
MIT License
20 stars 1 forks source link

Long urls breaks table responsiveness #7

Closed GabLeRoux closed 6 years ago

GabLeRoux commented 6 years ago

image

I tried to add the following .break-all class:

https://github.com/GabLeRoux/webextensions-history-browser/blob/a001096be5e103950a573a9da5063b7838c8b59e/src/css/main.css#L1-L4

on the anchor tag here: https://github.com/GabLeRoux/webextensions-history-browser/blob/a001096be5e103950a573a9da5063b7838c8b59e/src/js/history.js#L75

but the column width gets too small:

image

We should try to resize columns, maybe use something like jeffreydwalter/ColReorderWithResize (see it in action)

GabLeRoux commented 6 years ago

As explained in 1642c50 message

Note: this introduces an issue when resizing columns where contents gets removed or replaced randomly. Maybe it's broken or there's something wrong with recent versions of dataTable :(

We need to find a fix for the data disappearing when using jeffreydwalter/ColReorderWithResize or find another solution.

GabLeRoux commented 6 years ago

Oh nervermind, it works as expected. Problem happens when we actually click the header. It was due to column ordering which was totally confusing me.

So maybe we should find a way to order columns only by clicking the ordering icon and not the whole header. I'm ok with that 🎉