GabMus / HydraPaper

A Gtk utility to set two different backgrounds for each monitor on GNOME (which lacks this feature)
GNU General Public License v3.0
169 stars 18 forks source link

UI refreshes too often #15

Open alex285 opened 6 years ago

alex285 commented 6 years ago

I guess you're aware of most UI issues, but here is one you might have missed. When you download wallpapers, those might have very long names ..as you can see on screenshot

screenshot from 2018-02-03 01-42-58

Two more issues here is that

  1. The selection gets the full height
  2. When you remove a favorite (or when you add one), the view is refreshing all the items, while there is also a lock
GabMus commented 6 years ago
  1. Tried to solve that, had no luck. This is pretty low in priority tho, will try to fix it when I can.

  2. Yeah, the UI refresh is one of the weakest points of this app. Will have to make a subclass of FlowBoxItem and do some wizardry to make it a little better. It's in the works tho.

GabMus commented 6 years ago

Tried to fix the label issue, and mitigate in some way the ui refresh slowness. Still, removing the locks causes problems in most cases, so I think they'll be there for a while, until I figure out a better way to populate/update the flowboxes.

Here's a flatpak that you can test

hydrapaper-246c002.zip

alex285 commented 6 years ago

@GabMus thank you! the title is fine now!

GabMus commented 6 years ago

Fixed "selection gets full height" in c050e78.

Here you can test it.

hydrapaper-c050e78.zip

alex285 commented 6 years ago

@GabMus question: why you dont just update the flatpak repo, since you obviously fix things?

GabMus commented 6 years ago

You mean the released package? There are some things I'm still not convinced about. Want to make a bigger release.

GabMus commented 6 years ago

reduced ui refreses in 80b085c

GabMus commented 6 years ago

did some general improvements to reduce UI refresh, here's a new flatpak:

hydrapaper-1.1.3-28-gd1622bf.zip

alex285 commented 6 years ago

@GabMus where the "Favorites" view has gone? i mean it is gone :)

GabMus commented 6 years ago

It goes away if you don't have any favorites. Add some and you will see it appear in the top stack switcher

GabMus commented 6 years ago

Did a little visual fix, here's an updated flatpak:

hydrapaper-1.1.3-29-g44c0181.zip

GabMus commented 6 years ago

Fixed some issues, new flatpak: hydrapaper-1.1.3-30-g2cf4fe3.zip