Cannot Create Keyboard Macro

[vozeldr]

This is when trying to create a keyboard macro on my Blackwidow Chroma.

Traceback (most recent call last): File "/home/xxxxx/Projects/razerCommander/razercommander/main.py", line 882, in on_macroShortcutDialogOk_clicked if set_shortcut_stack.get_visible_child_name() == 'Keystroke': NameError: name 'set_shortcut_stack' is not defined

[GabMus]

What version of razercommander do you have? main.py in the root of the git repo doesn't exist anymore

[vozeldr]

I cloned the latest git repo and followed the instructions here to build and run it... https://github.com/GabMus/razerCommander#building-for-testing

[GabMus]

Sounds unlikely... Please try cloning again and compiling in a new folder. Also, what distro are you on?

[vozeldr]

I'm on Ubuntu 17.10 upgraded from 17.04. Here is the output from the console of a fresh clone, build and run (all I did is find/replace my computer and user name). The first couple of lines is me backing up and removing the configuration files for razerCommander for a fresh start.

uname@cname:~/.config$ tar -czvf razercommander.tgz razercommander
razercommander/
razercommander/macro_logic.json
razercommander/profiles
uname@cname:~/.config$ rm -rf razercommander
uname@cname:~/.config$ cd openrazer
uname@cname:~/.config/openrazer$ ls
razer.conf
uname@cname:~/.config/openrazer$ cd ../
uname@cname:~/.config$ mv razercommander.tgz /data
uname@cname:~/.config$ cd ../Projects/
uname@cname:~/Projects$ git clone git@github.com:GabMus/razerCommander.gitCloning into 'razerCommander'...
remote: Counting objects: 1028, done.
remote: Compressing objects: 100% (17/17), done.
remote: Total 1028 (delta 7), reused 13 (delta 4), pack-reused 1007
Receiving objects: 100% (1028/1028), 9.93 MiB | 2.30 MiB/s, done.
Resolving deltas: 100% (485/485), done.
uname@cname:~/Projects$ cd razerCommander/
uname@cname:~/Projects/razerCommander$ mkdir builddir
uname@cname:~/Projects/razerCommander$ cd builddir
uname@cname:~/Projects/razerCommander/builddir$ meson ..
The Meson build system
Version: 0.42.1
Source dir: /home/uname/Projects/razerCommander
Build dir: /home/uname/Projects/razerCommander/builddir
Build type: native build
Project name: razercommander
Build machine cpu family: x86_64
Build machine cpu: x86_64
Configuring org.gabmus.razercommander.desktop using configuration
Configuring org.gabmus.razercommander.service using configuration
Found pkg-config: /usr/bin/pkg-config (0.29.1)
Native dependency glib-2.0 found: YES 2.54.1
Program glib-compile-schemas found: YES (/usr/bin/glib-compile-schemas)
Configuring razercommander using configuration
Program scripts/meson_post_install.py found: YES (/usr/bin/env python3 /home/uname/Projects/razerCommander/scripts/meson_post_install.py)
Build targets in project: 3
uname@cname:~/Projects/razerCommander/builddir$ meson configure -Dprefix=$(pwd)/testdir
uname@cname:~/Projects/razerCommander/builddir$ ninja install
[0/1] Regenerating build files.
The Meson build system
Version: 0.42.1
Source dir: /home/uname/Projects/razerCommander
Build dir: /home/uname/Projects/razerCommander/builddir
Build type: native build
Project name: razercommander
Build machine cpu family: x86_64
Build machine cpu: x86_64
Configuring org.gabmus.razercommander.desktop using configuration
Configuring org.gabmus.razercommander.service using configuration
Found pkg-config: /usr/bin/pkg-config (0.29.1)
Native dependency glib-2.0 found: YES 2.54.1
Program glib-compile-schemas found: YES (/usr/bin/glib-compile-schemas)
Configuring razercommander using configuration
Program scripts/meson_post_install.py found: YES (/usr/bin/env python3 /home/uname/Projects/razerCommander/scripts/meson_post_install.py)
Build targets in project: 3
[1/2] Generating org.gabmus.razercommander_gresource with a custom command.
XMLLINT not set and xmllint not found in path; skipping xml preprocessing.
[1/2] Installing files.
Installing subdir /home/uname/Projects/razerCommander/razercommander to /home/uname/Projects/razerCommander/builddir/testdir/lib/python3.6/site-packages
Installing data/org.gabmus.razercommander.gresource to /home/uname/Projects/razerCommander/builddir/testdir/share/razercommander/org.gabmus.razercommander.gresource
Installing /home/uname/Projects/razerCommander/builddir/data/org.gabmus.razercommander.desktop to /home/uname/Projects/razerCommander/builddir/testdir/share/applications
Installing /home/uname/Projects/razerCommander/builddir/data/org.gabmus.razercommander.service to /home/uname/Projects/razerCommander/builddir/testdir/share/dbus-1/services
Installing /home/uname/Projects/razerCommander/data/icons/org.gabmus.razercommander.svg to /home/uname/Projects/razerCommander/builddir/testdir/share/icons/hicolor/scalable/apps
Installing /home/uname/Projects/razerCommander/builddir/bin/razercommander to /home/uname/Projects/razerCommander/builddir/testdir/bin
Running custom install script '/usr/bin/env python3 /home/uname/Projects/razerCommander/scripts/meson_post_install.py'
Compiling gsettings schemas...
Error opening directory “/home/uname/Projects/razerCommander/builddir/testdir/share/glib-2.0/schemas”: No such file or directory
Updating icon cache...
Updating desktop database...
Compiling python bytecode...
Listing '/home/uname/Projects/razerCommander/builddir/testdir/lib/python3.6/site-packages/razercommander'...
Compiling '/home/uname/Projects/razerCommander/builddir/testdir/lib/python3.6/site-packages/razercommander/__main__.py'...
Compiling '/home/uname/Projects/razerCommander/builddir/testdir/lib/python3.6/site-packages/razercommander/confFileManager.py'...
Compiling '/home/uname/Projects/razerCommander/builddir/testdir/lib/python3.6/site-packages/razercommander/custom_kb_builder.py'...
Compiling '/home/uname/Projects/razerCommander/builddir/testdir/lib/python3.6/site-packages/razercommander/custom_keyboard.py'...
Compiling '/home/uname/Projects/razerCommander/builddir/testdir/lib/python3.6/site-packages/razercommander/custom_profiles.py'...
Compiling '/home/uname/Projects/razerCommander/builddir/testdir/lib/python3.6/site-packages/razercommander/device.py'...
Compiling '/home/uname/Projects/razerCommander/builddir/testdir/lib/python3.6/site-packages/razercommander/devicesMacroKeys.py'...
Compiling '/home/uname/Projects/razerCommander/builddir/testdir/lib/python3.6/site-packages/razercommander/kblayouts.py'...
Compiling '/home/uname/Projects/razerCommander/builddir/testdir/lib/python3.6/site-packages/razercommander/listboxHelper.py'...
Compiling '/home/uname/Projects/razerCommander/builddir/testdir/lib/python3.6/site-packages/razercommander/macro_logic.py'...
uname@cname:~/Projects/razerCommander/builddir$ ninja run
[0/1] Running external command run.
Importing device logic, waiting for daemon
Device logic loaded, daemon is alive
Traceback (most recent call last):
  File "/home/uname/Projects/razerCommander/razercommander/__main__.py", line 245, in initDevices
    newdev = device.Device(dev)
  File "/home/uname/Projects/razerCommander/razercommander/device.py", line 50, in __init__
    self.device)
  File "/home/uname/Projects/razerCommander/razercommander/macro_logic.py", line 73, in make_device
    n_device = MacroDevice(mk_arr, device_uid, device)
  File "/home/uname/Projects/razerCommander/razercommander/macro_logic.py", line 14, in __init__
    self.set_all_current_macros()
  File "/home/uname/Projects/razerCommander/razercommander/macro_logic.py", line 32, in set_all_current_macros
    key.set_current_macro(self.device)
  File "/home/uname/Projects/razerCommander/razercommander/macro_logic.py", line 50, in set_current_macro
    self._set_macro(device, self.macro)
  File "/home/uname/Projects/razerCommander/razercommander/macro_logic.py", line 43, in _set_macro
    device.macro.del_macro(self.key)
  File "/usr/lib/python3/dist-packages/openrazer/client/macro.py", line 66, in del_macro
    raise ValueError("Key {0} is not in openrazer.keyboard.KEY_MAPPING".format(bind_key))
ValueError: Key 10 is not in openrazer.keyboard.KEY_MAPPING

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/uname/Projects/razerCommander/razercommander/__main__.py", line 687, in do_command_line
    self.do_activate()
  File "/home/uname/Projects/razerCommander/razercommander/__main__.py", line 661, in do_activate
    self.refreshDevices()
  File "/home/uname/Projects/razerCommander/razercommander/__main__.py", line 302, in refreshDevices
    self.initDevices()
  File "/home/uname/Projects/razerCommander/razercommander/__main__.py", line 248, in initDevices
    print('Skipping device: {}'.format(device.name))
AttributeError: module 'razercommander.device' has no attribute 'name'

[vozeldr]

Also, my python version is Python 3.6.3 and openrazer version 2.1.1~ubuntu17.10.1

[vozeldr]

In order to get past this error and run the program (I submitted this fix in another issue), on line 248 of __main__.py change device.name to dev.name (also... when you see main.py in these issues where main is bold, that's because __ in markdown means bold... I had to wrap it in ticks to stop that).

Afterwards, I can successfully run the program and I see the following in the console.

[0/1] Running external command run.
Importing device logic, waiting for daemon
Device logic loaded, daemon is alive
Skipping device: Razer Tartarus Chroma

I've confirmed that changing the color effects on all 3 of the listed devices works fine.

[vozeldr]

So after that, back to the original issue...

[0/1] Running external command run.
Importing device logic, waiting for daemon
Device logic loaded, daemon is alive
Skipping device: Razer Kraken 7.1 Chroma (Rainie)
Traceback (most recent call last):
  File "/home/uname/Projects/razerCommander/razercommander/__main__.py", line 880, in on_macroShortcutDialogOk_clicked
    if set_shortcut_stack.get_visible_child_name() == 'Keystroke':
NameError: name 'set_shortcut_stack' is not defined

That happens after choosing my Razer BlackWidow Chroma, hitting Macros, clicking Unassigned to bring up the dialog. The same error message displays when I hit the OK button whether I try recording a keystroke or entering an xdotool command manually.

[vozeldr]

OK, I fixed the issues locally by adding self in front of set_shortcut_stack on line 880 of __main__.py... so the TLDR from all of this is to make these 2 changes.

Line 248: print('Skipping device: {}'.format(dev.name))
Line 880: if self.set_shortcut_stack.get_visible_child_name() == 'Keystroke':

After making these changes, the application runs well. It displays the correct skipped device in the terminal output and I'm able to save macros. Here is a patch (it won't allow a .patch file to be attached)

Index: razercommander/__main__.py
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- razercommander/__main__.py  (revision ab9d8a326ab23c17c70f4f85d4d202edccefb714)
+++ razercommander/__main__.py  (date 1512059000000)
@@ -245,7 +245,7 @@
                 newdev = device.Device(dev)
                 self.devicesList.append(newdev)
             except:
-                print('Skipping device: {}'.format(device.name))
+                print('Skipping device: {}'.format(dev.name))
                 pass
         if len(self.devicesList) > 0:
             self.active_razer_device = self.devicesList[0]
@@ -877,7 +877,7 @@
             self.macro_shortcut_dialog.show()

     def on_macroShortcutDialogOk_clicked(self, btn):
-        if set_shortcut_stack.get_visible_child_name() == 'Keystroke':
+        if self.set_shortcut_stack.get_visible_child_name() == 'Keystroke':
             n_macro = 'xdotool key {}'.format(self.macro_current_keystroke_label.get_text())
         else:
             n_macro = self.macro_shortcut_entry.get_text()

[GabMus]

thanks for the patch, I applied it and now it should work. please test it out and let me know.

[vozeldr]

It appears to be working fine now, thanks!