ScotteRoberts commented 2 years ago

Pull Request Template

Checks and guidelines

[x] Have you checked that there aren't other open Pull Requests for the same update/change?
[ ] Linting passed yarn lint:ci
[ ] Integration tests added
[ ] Tests passed yarn test:dev
[ ] Build passed yarn build:ci

Type of change

[x] Bug fix
[ ] New feature
[ ] Improvement
[ ] Breaking change
[ ] Documentation update
[ ] Security

Describe the changes

I've changed this because the types were breaking when using the Pokemon interface

Spelling error:

Argument of type '{ abilities: { ability: { name: string; url: string; }; is_hidden: boolean; slot: number; }[]; base_experience: number; forms: { name: string; url: string; }[]; game_indices: { game_index: number; version: { name: string; url: string; }; }[]; ... 13 more ...; weight: number; }' is not assignable to parameter of type 'Pokemon | (() => Pokemon)'.
  Type '{ abilities: { ability: { name: string; url: string; }; is_hidden: boolean; slot: number; }[]; base_experience: number; forms: { name: string; url: string; }[]; game_indices: { game_index: number; version: { name: string; url: string; }; }[]; ... 13 more ...; weight: number; }' is not assignable to type 'Pokemon'.
    The types of 'sprites.versions["generation-iv"]' are incompatible between these types.
      Property '"diamond-perl"' is missing in type '{ "diamond-pearl": { back_default: string; back_female: null; back_shiny: string; back_shiny_female: null; front_default: string; front_female: null; front_shiny: string; front_shiny_female: null; }; "heartgold-soulsilver": { ...; }; platinum: { ...; }; }' but required in type 'GenerationIVSprites'.ts(2345)
index.d.ts(1485, 2): '"diamond-perl"' is declared here.

Effort Fix:

Argument of type '{ abilities: { ability: { name: string; url: string; }; is_hidden: boolean; slot: number; }[]; base_experience: number; forms: { name: string; url: string; }[]; game_indices: { game_index: number; version: { name: string; url: string; }; }[]; ... 13 more ...; weight: number; }' is not assignable to parameter of type 'Pokemon | (() => Pokemon)'.
  Type '{ abilities: { ability: { name: string; url: string; }; is_hidden: boolean; slot: number; }[]; base_experience: number; forms: { name: string; url: string; }[]; game_indices: { game_index: number; version: { name: string; url: string; }; }[]; ... 13 more ...; weight: number; }' is not assignable to type 'Pokemon'.
    Types of property 'stats' are incompatible.
      Type '{ base_stat: number; effort: number; stat: { name: string; url: string; }; }[]' is not assignable to type 'PokemonStat[]'.
        Type '{ base_stat: number; effort: number; stat: { name: string; url: string; }; }' is not assignable to type 'PokemonStat'.
          Types of property 'effort' are incompatible.
            Type 'number' is not assignable to type '0 | 1 | 2 | 3'.ts(2345)