Gabb-c / pokenode-ts

A lightweight Node.js wrapper for the PokéAPI with built-in types.
https://pokenode-ts.vercel.app/
MIT License
244 stars 28 forks source link

fix: add past relations to Pokemon/Type #806

Closed MrKarbrador closed 1 year ago

MrKarbrador commented 1 year ago

Pull Request Template

Checks and guidelines

Type of change

Describe the changes

I've added the past_damage_relations to the Type interface (and a TypeRelationsPast interface), as described in the api-documentation (https://pokeapi.co/docs/v2#types)

vercel[bot] commented 1 year ago

Someone is attempting to deploy a commit to a Personal Account owned by @Gabb-c on Vercel.

@Gabb-c first needs to authorize it.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

github-advanced-security[bot] commented 1 year ago

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

Gabb-c commented 1 year ago

Hey @MrKarbrador, thanks for your input! Can you also update the docs with the new typings that you added? Than I'll soon merge your PR

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
pokenode-ts ❌ Failed (Inspect) Mar 24, 2023 at 4:44PM (UTC)
MrKarbrador commented 1 year ago

Hey, thank you for the response. The dev-branch does not have the docs should i redo the PR on the master?